steakhal added a comment. Thanks for fixing this @stevewan!
I think disabling a test is worse than actually fixing it, although I can see the frustration it causes. Yet, I would propose something else. This is just a static analyzer checker doing its own thing. What if we were pinning the target triple before conducting the analysis run? The platform on which the test runs shouldn't matter. Or even better, setting a bunch of target triples and letting //gtest// to run each one to see if it still passes on **all** triples. I haven't checked, but I think `clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp` does something similar by using the `INSTANTIATE_TEST_SUITE_P` macro. --- If you insist, I think a conditional `GTEST_SKIP() << "my message";` should be prefered to simply disable a test. By doing this, you can specify the reason why was the test disabled. That being said, the macro stuff would get much cleaner this way. But I still prefer pinning the triple. See my previous comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
