gandhi21299 added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_trivial_copy) ---------------- rjmccall wrote: > I'm confused about what's happening here. You're editing comments to make > more tendentious claims, and then adding FIXMEs to make charged questions > about your own claims? Did you consider just not editing the comments? Ahh I totally missed this, my apologies. I will revert this patch and get rid of this comment. Thanks for pointing it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits