mstorsjo added a comment.

In D114651#3156374 <https://reviews.llvm.org/D114651#3156374>, @zero9178 wrote:

> Is the deviation from MSVC behaviour here intentional? MSVC flags allow both 
> using a `/` as well as `-` as prefix. That means Both `-Wall` and `/Wall` are 
> accepted by MSVC as well as clang-cl and in both compilers currently lead to 
> ALL warnings being emitted. So this patch would deviate from that behaviour 
> as well as add confusion as every other option behaves the same in MSVC and 
> clang-cl, regardless of whether `-` or `/` is used as prefix.

+1, while it's annoying with `-Wall` not doing the expected thing when using 
(clang-)cl, that's to be expected - cl and gcc style drivers have entirely 
different options overall, so one generally have to take care and use the right 
kind of options for them (and it's just a bit inconvenient that some options 
overlap but differ). So specialcasing an exception for this particular option 
doesn't seem worth it. Even in the context of cl-only options, I tend to always 
use the slash form, because there's less risk of mixups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114651/new/

https://reviews.llvm.org/D114651

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to