compnerd added inline comments.
================ Comment at: clang/docs/UsersManual.rst:3546 - cmake -G"Visual Studio 15 2017" -T LLVM .. + cmake -G"Visual Studio 17 2022" -T LLVM .. ---------------- Meinersbur wrote: > jhenderson wrote: > > RKSimon wrote: > > > aaron.ballman wrote: > > > > jhenderson wrote: > > > > > I think the missing space should be fixed to :) > > > > +1 to the missing space. > > > This one is confusing - it isn't in my local diff, the raw diff, or if I > > > reapply the raw diff - it looks to have just appeared when you quote it > > > in phab comments? > > The fact that the space is missing? It's missing in the current repo too. > It works with and without the space, like `-GNinja` and `-G Ninja` both work. It would be nice to mention the CMake minimum version. I think that you need 3.22 or newer for the 2022 generator/toolset definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits