nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2506 + def : Pat<(v16i8 (int_ppc_altivec_crypto_vpermxor_be v16i8:$a, + v16i8:$b, v16i8:$c)), + (v16i8 (VPERMXOR $a, $b, $c))>; ---------------- Nit: the `v16i8` should be aligned with the `v16i8` above. ================ Comment at: llvm/test/CodeGen/PowerPC/crypto_bifs_be.ll:8 +; RUN: -mcpu=pwr8 < %s | FileCheck %s --check-prefixes=CHECK-BE-P8 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \ +; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefixes=CHECK-P9 ---------------- There isn't really any difference in how we handle this on P9 so this run line is probably superfluous. Feel free to get rid of it when pushing this upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114540/new/ https://reviews.llvm.org/D114540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
