eugenis accepted this revision.
eugenis added a comment.
LGTM
================
Comment at: clang/test/CodeGen/asan-globals.cpp:62
// CHECK: ![[ATTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true}
+// CHECK: ![[DISABLE_INSTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true}
// CHECK: ![[BLACKLISTED_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true}
----------------
Does this test rely on the metadata being in the same order as the global
declarations in the source? Feels brittle and hard to understand - could you
check if the regexps could be made more precise?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114421/new/
https://reviews.llvm.org/D114421
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
