Anastasia added inline comments.
================
Comment at: clang/docs/UsersManual.rst:3559
+by the OpenCL driver that support SPIR-V consumption or it can be compiled
further
+by offline SPIR-V consumer tools.
+
----------------
Btw do we want to say anything about the limitations of translating IR when
optimizations are enabled?
================
Comment at: clang/test/Driver/spirv-toolchain.cl:10
+// SPV64-SAME: "-o" [[BC:".*bc"]]
+// SPV64: {{".*llvm-spirv.*"}} [[BC]] "-o" {{".*o"}}
+
----------------
svenvh wrote:
> Any reason to not just check for `llvm-spirv{{.*}}`, for consistency with the
> clang check above?
Good question, apparently some tools get some target prefixes like if you look
at `Driver::generatePrefixedToolNames`:
https://clang.llvm.org/doxygen/Driver_8cpp_source.html#l05169
But perhaps it doesn't happen for `llvm-spirv` and we can safely omit the
prefix?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112410/new/
https://reviews.llvm.org/D112410
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
