aganea added inline comments.
================ Comment at: clang/lib/Driver/Job.cpp:391 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). ---------------- I changed this to match the behavior of the //main function//, ie. `argv[argc]` is guaranteed to be a null pointer. Please let me know if you disagree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116011/new/ https://reviews.llvm.org/D116011 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
