zixuan-wu added inline comments.
================
Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:33
+ bool operator!=(const RISCVExtensionVersion &Version) const {
+ return !operator==(Version);
+ }
----------------
craig.topper wrote:
> Use `!(*this == Version)`
Good taste.
================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:91
StringRef ABIName) {
+ initializeEnvironment();
// Determine default and user-specified characteristics
----------------
craig.topper wrote:
> Why do we need to initialize things now but didn't before?
After the constructor is workable to initialize, no need for
initializeEnvironment. So remove it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115921/new/
https://reviews.llvm.org/D115921
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
