compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': + root_sep = 'C:\\' +else: ---------------- This isn't really a separator, this is the root itself. I think that it makes sense to name it accordingly. Please do not hard code this to `C:\`. There is no guarantee that the root is `C:\`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
