lenary added a comment. In D114206#3221950 <https://reviews.llvm.org/D114206#3221950>, @Bigcheese wrote:
> In D114206#3221893 <https://reviews.llvm.org/D114206#3221893>, @lenary wrote: > >> Update: I'm going to revert this on main. This patch was accepted >> conditionally on you fixing the windows crash, which you have not done, so >> this was landed without being accepted. >> >> Revert is here: https://reviews.llvm.org/rGea835171389a >> >> When you re-land this, don't forget to include the changes from D116611 >> <https://reviews.llvm.org/D116611>, please. > > There is no crash on Windows with this patch. The issue is if you pass > `main.m` instead of `DIR/main.m`. The commit that landed had both fixes I > mentioned. Did you try this on Windows or look at the bots? In the future > please be more careful. I did try this on windows, and I'm still seeing a crash about traversal segments, I'll continue investigating that crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/ https://reviews.llvm.org/D114206 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
