martong added a comment. In D114622#3200678 <https://reviews.llvm.org/D114622#3200678>, @NoQ wrote:
> These checks are almost 2000 lines of code each and it looks like all they do > is figure out if two statements are the same and we have a very flexible > reusable solution for this sort of stuff - `CloneDetector`, but none of them > use it. Your patch demonstrates that they all have the same bugs that need to > be fixed in each of them separately, so reusability seems really valuable. If > I was to work on these checks, the first thing I'd try would be to throw out > their machines and plug in a reusable solution. There are already two way more sophisticated (forgive me my bias) implementations in Clang that are for checking if two statements or decls are the same. 1. ODRHash, used in modules to discover ODR violations 2. ASTStructuralEquivalenceContext, used in ASTImporter to discover if two AST nodes are the same or not (as a side effect we diagnose ODR violations as well). It is not the first time, when such a similarity check is needed (see https://reviews.llvm.org/D75041). Of course reusing the before mentioned components would require some architectural changes, but it might be beneficial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
