carlosgalvezp added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:442
+        if (PrimaryCheckValue != Value) {
+          std::cout << "Alias check \"" << CheckName.str() << "\" of \""
+                    << PrimaryCheckName.str() << "\""
----------------
Jeroen wrote:
> I'm not sure if you have this in for testing purpose or not, though I really 
> like to have this message. If I would be having 2 aliases active with 
> different options, it would be nice to know about that. So please keep this 
> in!
> Preferably, we would only configure it once, though that's dreaming.
Yep, all printouts are just for my own testing, but good to hear it's useful 
info for production! I'll see if I get some time and clean this up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114317/new/

https://reviews.llvm.org/D114317

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D114317: [cla... Jeroen Van Antwerpen via Phabricator via cfe-commits
    • [PATCH] D114317:... Carlos Galvez via Phabricator via cfe-commits

Reply via email to