sammccall marked an inline comment as done. sammccall added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:14995 + DeclFilterCCC<FunctionDecl> CCC{}; + Corrected = CorrectTypo(DeclarationNameInfo(&II, Loc), LookupOrdinaryName, + S, nullptr, CCC, CTK_NonError); ---------------- kadircet wrote: > maybe some comments around importance of the sequencing here? it would > probably be nice to have that at a higher level documentation too, but > unclear where. as in theory it's not just about the typo correction but also > emitting diagnostics while doing so. Yeah, this is obviously pretty hacky, and I don't have great ideas to improve it. Added a comment to leave some breadcrumbs and discourage moving this code around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115490/new/ https://reviews.llvm.org/D115490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits