DavidSpickett added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745
+                 IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>,
+                 Requires<[IsThumb2]>, Sched<[WriteBrL]>;
----------------
Should this require `IsMClass` instead/also? Though I wasn't able to get 
anything weird to happen when using an A profile triple so maybe I'm missing a 
check elsewhere that means you'd never get to this point with A profile Arm.

For example this A profile triple:
```
$ ./bin/clang --target=thumbv8-arm-none-eabi /tmp/test.c -o /tmp/test.o -o - -S 
-mbranch-protection=bti -mthumb
```

Doesn't put anything after a call to `setjmp`, nop or otherwise, but I can't 
place where that decision is made.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112427/new/

https://reviews.llvm.org/D112427

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to