jansvoboda11 added a comment.

In D116750#3234261 <https://reviews.llvm.org/D116750#3234261>, @thakis wrote:

> 1. `which is stable thanks to the bump-ptr-allocation strategy.` I don't 
> understand this. In each slab, that's true, but why is it true between 
> objects allocated in different slabs?

That's referring to the fact that once we allocate new `DirectoryLookup` with 
`SpecificBumpPtrAllocator`, address of that object won't change (unlike with 
`std::vector`). This means that we can take the address and use it without 
worrying about invalidation.

> 2. This increases numbers of TUs compiled for LexTests by over 10%. Is there 
> no way around that Frontend dep?

I'll look into moving `clang::ApplyHeaderSearchOptions` from `Frontend` into 
`Lex`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116750/new/

https://reviews.llvm.org/D116750

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to