njames93 added a comment. In D117129#3246610 <https://reviews.llvm.org/D117129#3246610>, @LegalizeAdulthood wrote:
> In D117129#3246403 <https://reviews.llvm.org/D117129#3246403>, @njames93 > wrote: > >> > > I pushed the functionality down into ClangTidyCheck > instead of introducing an intermediate class. Does this > address your concern? This is a step backwards. Now every check is paying for an IncludeInserter that most never use. I've put D117409 <https://reviews.llvm.org/D117409> up that, despite being a little rough round the edges, solves the problem in a way where there is only 1 shared Inserter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117129/new/ https://reviews.llvm.org/D117129 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
