sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang-tools-extra/clangd/Selection.cpp:551
   printNodeKind(OS, N);
   OS << " ";
   return std::move(OS.str());
----------------
hmm, while here, this extra space seems weird.

Previously it was at EOL and invisible.

After this patch it's used, but I think it'd be clearer to move it to the 
format string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117475/new/

https://reviews.llvm.org/D117475

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to