ABataev added a comment.

In D70549#3256063 <https://reviews.llvm.org/D70549#3256063>, @JonChesterfield 
wrote:

> @ABataev @jhuber6 and I would like to change this to annotate variables with 
> whatever visibility the user asked for.
>
> Can you recall if the concern about premption here was for the deviceRTL, in 
> which case it can be comprehensively dealt with by internalizing the 
> deviceRTL symbols, or for user defined things in which case we want whatever 
> the linker flag -Bsymbolic maps onto as an IR construct.

Hi, check the original PR, it has all required details. Maybe add a check that 
if the device is same as the host, then add hidden visibility (to avoid 
problems with the standard libs etc.), otherwise keep it as is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70549/new/

https://reviews.llvm.org/D70549

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D70549: [OPENMP]F... Jon Chesterfield via Phabricator via cfe-commits
    • [PATCH] D70549: [OPE... Alexey Bataev via Phabricator via cfe-commits

Reply via email to