aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D116966#3261202 <https://reviews.llvm.org/D116966#3261202>, @ArcsinX wrote: > In D116966#3261168 <https://reviews.llvm.org/D116966#3261168>, @aaron.ballman > wrote: > >> However, the changes you've made don't look to be specific to building on >> Windows; this removes `PLUGIN_TOOL` for all targets. I presume it's still >> needed for non-Windows targets, isn't it? > > As I can see, `PLUGIN_TOOL` is unused for non-Windows OS (at least for now): > https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/AddLLVM.cmake#L648 Yeah, that seems to be the case. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116966/new/ https://reviews.llvm.org/D116966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
