benshi001 marked an inline comment as done.
benshi001 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5149
+ // Devices in the avr-1 family only support assembly programming.
+ if (TC.getArch() == llvm::Triple::avr) {
+ auto const &AVRTC = static_cast<const toolchains::AVRToolChain &>(TC);
----------------
MaskRay wrote:
> Try moving the check from the generic file to the toolchain-specific file.
I have created another patch to do this check in avr toolchain specific files.
https://reviews.llvm.org/D118095
which is much more complex than current solution.
But I do see there are other target specific checks in the common
`Clang::ConstructJob`, such as
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L5153
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L5019
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L5257
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117423/new/
https://reviews.llvm.org/D117423
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
