yaxunl marked 2 inline comments as done. ================ Comment at: test/Headers/opencl-c-header.cl:70 @@ +69,3 @@ +// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck %s +// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck --check-prefix=CHECK20 %s +// RUN: %clang_cc1 -triple amdgcn--amdhsa -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck --check-prefix=CHECK20 %s ---------------- Anastasia wrote: > yaxunl wrote: > > I added check to the second compilation to make sure module is read, also > > changed the modules to be read only so that they won't be created again. > Ok, now I see what you are testing here. :) > > Do you think we could add: > CHECK-NOT: Reading modules > > For the cases the modules are regenerated new? In the case the modules are generated as new, Clang will generate the module first and then load it. So in the time report, you still see 'Reading modules'.
http://reviews.llvm.org/D20444 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
