tra added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:3445
def mcode_object_version_EQ : Joined<["-"], "mcode-object-version=">,
Group<m_Group>,
- HelpText<"Specify code object ABI version. Defaults to 4. (AMDGPU only)">,
- MetaVarName<"<version>">, Values<"2,3,4,5">;
+ HelpText<"Specify code object ABI version. Allowed values are 2, 3, 4, and
5. Defaults to 4. (AMDGPU only)">,
+ Flags<[CC1Option]>,
----------------
`none` is missing. I'm not sure if we need to enumerate all values -- the list
will eventually grow unacceptably long.
Does the option parser print allowed values on error? That would be sufficient,
IMO.
Up to you.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1166
CmdArgs.insert(CmdArgs.begin() + 1, "-mllvm");
+ // -cc1as does not need -mcode-object-version option.
+ if (!IsCC1As)
----------------
Do we really need a special case for `-cc1as`? What happens if we do pass the
option to it?
If cc1as does need a special case handling, we may want to add a test case for
that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119026/new/
https://reviews.llvm.org/D119026
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
