thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
I think this looks great.
maskray, I kind of see where you're coming from. And I'm _very_ sympathetic to
keeping Support small(er). On the other hand, this is a single file that
doesn't require any additional dependencies on libs (…I think), so a dedicated
library feels a bit overkill to me, maybe. (Are there any "when not to put your
stuff in Support" guidelines anywhere?)
================
Comment at: lld/COFF/Driver.cpp:172
+// specific header files. If not, they are probably shipped with Universal CRT.
+static bool useUniversalCRT(ToolsetLayout VSLayout,
+ const std::string &VCToolChainPath) {
----------------
Maybe this function could be in the shared part too? Looks like basically
exactly this code is in both places.
================
Comment at: lld/docs/ReleaseNotes.rst:38
+* Added autodetection of MSVC toolchain, a la clang-cl.
+ (`D118070 <https://reviews.llvm.org/D118070>`_)
* ...
----------------
Maybe mention /winsysroot: here too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118070/new/
https://reviews.llvm.org/D118070
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
