krzysz00 added a comment.

Having checked with other folks more familiar with the context of our project, 
it looks like we might actually be fine using lld as a subprocess, since we'll 
always be sitting on top of a ROCm installation, which includes lld, and since 
"take this object file and wrap it into a shared library" is extremely unlikely 
to be broken by version changes.

That being said, I've also heard that when this code was initially landing (as 
part of mlir-rocm-runner, and before my time), the feedback was to use lld as a 
library and not a subprocess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119257/new/

https://reviews.llvm.org/D119257

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to