yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/lib/Sema/SemaCUDA.cpp:148-150
+ if ((Var->isConstexpr() || Var->getType().isConstQualified()) &&
+ Var->hasAttr<CUDAConstantAttr>() &&
!hasExplicitAttr<CUDAConstantAttr>(Var))
----------------
tra wrote:
> So the idea here is that the constexpr vars that have an initializer that may
> not be static enough for CUDA would not get the implicit __const__ attribute.
> I.e. it's tied to the change below that checks for allowed initializers.
> We could use a comment about that here.
will add a comment when committing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119615/new/
https://reviews.llvm.org/D119615
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
