labath added a comment.

Not my usual wheelhouse, but since I'm here, here are some of my thoughts:

- reusing the existing solution/code seems like a good idea -- no need to 
reinvent the wheel
- how does that work, actually? How does it differentiate between "my" code and 
"code that happens to be compiled in the current CU" (e.g. the STL).  What's 
the significance of the funky `__XXXXXXXX_x@c` symbols?
- if the goal is to integrate this into lldb (and given that lldb currently 
does not support any feature like this), I'd recommend sending an RFC/heads up 
early, to identify possible issues


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119910/new/

https://reviews.llvm.org/D119910

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to