tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments.
================ Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o - | FileCheck --check-prefix SIMD-ONLY0 %s +// %clang_cc1 -fopenmp-simd -fopenmp-version=51 -x c -triple x86_64-apple-darwin10 -target-cpu core2 -emit-pch -o %t %s ---------------- ABataev wrote: > tianshilei1992 wrote: > > CodeGen for `-fopen-simd` is wrong. It doesn't emit corresponding atomic > > operations. I'll fix it. > The logic behind -fopenmp-simd is to emit the code only for simd specific > instructions. Right. `// SIMD-ONLY0-NOT: {{__kmpc|__tgt}}` is used here, same as other cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits