aaron.ballman added a comment.

Hi, this commit is causing runtime failures on Windows in debug builds. Can you 
please correct or revert? Thanks!



================
Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119
+    ++End;
+  return llvm::makeArrayRef(&Actions[Start], &Actions[End]);
+}
----------------
This is causing an assertion with debug builds on Windows because 
`Actions[End]` is out of bounds (so the MSVC STL debug assertions catch the 
issue) for the test cases in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118196/new/

https://reviews.llvm.org/D118196

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to