erichkeane added a comment. In D120296#3345831 <https://reviews.llvm.org/D120296#3345831>, @yonghong-song wrote:
> @aaron.ballman Thanks for suggestion. Agree that Having a new Type is a > better idea. I guess, I will add BTFTagAttributeType which extends > AttributeType to see whether it works or not. It almost definitely does NOT want to extend AttributedType, but be its own type. VectorType/BitIntType are both somewhat good examples to follow (besides the 'dependent' version, since this is C only). That said, make sure you implement ExprConstant.cpp's visitors for your type so that you get these types to 'work' like normal types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
