ABataev added inline comments.

================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6216
-      KindsEncountered.contains(OMPC_capture)) {
-    IsCompareCapture = true;
     Kind = OMPC_compare;
----------------
tianshilei1992 wrote:
> ABataev wrote:
> > Can this be fixed in a separate patch?
> Well, I think it's part of this patch because we can't tell if it's compare 
> or compare capture before, but now we can. If we really want to do that, we 
> can have another patch including all changes in this patch related to 
> `OMPAtomicDirective`.
Kind of NFC? Would be good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120290/new/

https://reviews.llvm.org/D120290

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to