erichkeane added inline comments.
================
Comment at: clang/include/clang/Sema/ParsedAttr.h:920
void clearListOnly() { AttrList.clear(); }
----------------
Also, this function is now strange/likely needs a rename, since it likely needs
to reset the range as well. I believe the point of this being a separate
function is to not clear the 'pool'.
================
Comment at: clang/include/clang/Sema/ParsedAttr.h:1105
void clearListOnly() {
ParsedAttributesView::clearListOnly();
Range = SourceRange();
----------------
This is... oh boy. I'm hopeful you can remove this type as well.
================
Comment at: clang/test/SemaOpenCL/address-spaces.cl:261
typedef __private int private_int_t;
- __private __attribute__((opencl_global)) int var1; // expected-error
{{multiple address spaces specified for type}} \
+ __attribute__((opencl_global)) __private int var1; // expected-error
{{multiple address spaces specified for type}} \
// expected-error
{{function scope variable cannot be declared in global address space}}
----------------
tbaeder wrote:
> This is a peculiar ordering problem...
can you debug this to see what the problem is? I wouldn't expect the ordering
to matter here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121201/new/
https://reviews.llvm.org/D121201
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
