dexonsmith added a comment.

> Includes two test fixes (since chained mappings are no longer allowed)
> and adds a new test for multiple overlays.

Are we sure no one needs to support chained mappings? Has there been a 
~~clang-dev~~ discourse discussion about it already? Just concerned that some 
vendor might rely on being able to support this.



================
Comment at: llvm/include/llvm/Support/Error.h:1284
 
-  StringRef getFileName() { return FileName; }
+  StringRef getFileName() const { return FileName; }
 
----------------
bnbarham wrote:
> Should this be in a change all by itself?
Yes, but I also know you already split this out so I guess you just need to 
rebase :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121426/new/

https://reviews.llvm.org/D121426

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to