zixuan-wu added inline comments.
================ Comment at: clang/test/Driver/csky-arch.c:26 + +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s ---------------- rengolin wrote: > I don't think this is doing what you expect it to do. > > Depending on the output, you can still match all CHECK lines and not have the > output you want. > > To avoid issues, we usually separate tests that must pass (positive tests) > like the lines above 24, from tests that must fail (negative tests) like the > lines below. You mean separate into two files or two parts in one file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
