amilendra added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64.td:978
FeatureNEON, FeatureRCPC, FeaturePerfMon,
FeatureSPE, FeatureFullFP16, FeatureDotProd];
list<SubtargetFeature> X1C = [HasV8_2aOps, FeatureCrypto, FeatureFPARMv8,
----------------
stuij wrote:
> amilendra wrote:
> > stuij wrote:
> > > dmgreen wrote:
> > > > X1 and A77 missing SSBS too. Should they be added at the same time?
> > > Yes they should. Thanks!
> > Maybe add unit tests for X1 and A77 too?
> I did. See the top file.
>
> In general it'd be good to have better testing for individual cores. This
> will happen more structurally in future changes.
Ah yes, I was expecting tests similar to that for `R82` in
aarch64-target-features.c. Anyway what you have already is good for `ssbs`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121206/new/
https://reviews.llvm.org/D121206
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
