aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, feel free to add the assert when you land.
================ Comment at: clang/include/clang/Sema/ParsedAttr.h:813 void takeAllFrom(AttributePool &pool) { takePool(pool); pool.Attrs.clear(); ---------------- tbaeder wrote: > erichkeane wrote: > > so: `assert(&pool != this && "Stealing from yourself? Super bad...")`. > RIght, that's what I had locally. That's a reasonable assert to add. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits