I had given this some thought. I have a very limited knowledge of the code in this space. IIUC this only matters if the idea of linkage can change, which would happen only if a tag name needs manufacturing, which can only happen in the case we ran across (someone check my logic here?). The other thing that factored into my thinking is that this seemed to be the only reported downside. I don't feel qualified to make a decision whether moving the code farther down would be better.
On Thu, Mar 24, 2022 at 2:04 PM David Blaikie via Phabricator < revi...@reviews.llvm.org> wrote: > dblaikie added a comment. > > @aaron.ballman wouldn't mind your take on this to see if this seems > sufficiently robust, tested, etc. (should I move the isExternallyVisible > check even further down? So its side effects are even less impactful (maybe > there are other warnings that care about this sort of thing?) ) > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D121328/new/ > > https://reviews.llvm.org/D121328 > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
