bnbarham added inline comments.
================ Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); ---------------- dexonsmith wrote: > benlangmuir wrote: > > This parameter could use a comment, even if it just points you to read the > > FIXME in the implementation. > Good point; maybe it could have a better name/type, too, something like: > ``` > lang=c++ > Optional<StringRef> OverrideModuleMapFilename = None > ``` I believe this is actually the header name, but `Optional` + `OverrideFilename` seems worthwhile to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/new/ https://reviews.llvm.org/D123104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
