aaron.ballman added inline comments.
================ Comment at: llvm/include/llvm/ADT/StringExtras.h:329 +std::string to_hexString(uint64_t Value, bool UpperCase = true); + ---------------- cor3ntin wrote: > aaron.ballman wrote: > > `utohexstr()` already exists on line 152 -- any reason we can't reuse that? > I guess I missed that. Why do we have 2 functions doing the same thing? > How do you want me to clean that up? > I think we should have a separate nfc patch to clean that afterwards In this patch, I'd replace your new calls to `to_hexString()` with calls to `utohexstr()` and then in an NFC change, I'd get rid of `to_hexString()` entirely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
