junaire added a comment. I also find the code below really awkward:
S->getParent()->getFlags() & Scope::ControlScope I find that we have helpers like `Scope::isBlockScope()` `Scope::isisTryScope()` and etc, but no `Scope::isControlScope` and `Scope::isFnTryCatchScope` I will add these helpers as a NFC patch after this one, that won't need a release note or review right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
