tianshilei1992 marked 3 inline comments as done.
tianshilei1992 added inline comments.
================
Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847
bool IsXLHSInRHSPart = false;
/// Used for 'atomic update' or 'atomic capture' constructs. They may
/// have atomic expressions of forms
/// \code
/// v = x; <update x>;
/// <update x>; v = x;
/// \endcode
----------------
tianshilei1992 wrote:
> ABataev wrote:
> > Transform these booleans to bitfields?
> Will do in another patch.
In D123862.
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6216
- KindsEncountered.contains(OMPC_capture)) {
- IsCompareCapture = true;
Kind = OMPC_compare;
----------------
ABataev wrote:
> tianshilei1992 wrote:
> > ABataev wrote:
> > > Can this be fixed in a separate patch?
> > Well, I think it's part of this patch because we can't tell if it's compare
> > or compare capture before, but now we can. If we really want to do that, we
> > can have another patch including all changes in this patch related to
> > `OMPAtomicDirective`.
> Kind of NFC? Would be good
I think we don't need an extra NFC patch for this part because it's not gonna
be very neat w/o some other code in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120290/new/
https://reviews.llvm.org/D120290
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
