bc-lee added inline comments.
================ Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s -o - \ +// RUN: | llvm-readobj --file-headers --macho-version-min - \ ---------------- thakis wrote: > bc-lee wrote: > > MaskRay wrote: > > > `-filetype obj` on the `%clang -cc1as` line seems weird. > > Without this, I cannot create object file and validate it using > > `llvm-readobj`. > If you use `emit-obj` I think this test needs a `REQUIRES: > x86-registered-target`. > > I'm not sure if piping binary data works on Windows – it might have stdout in > text mode, which will do some byte replacements. A search for `-o -.*\n.*RUN.*llvm-readobj` in the LLVM codebase suggests that there are already several tests using that pattern. Does that really matter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
