jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed.
Can you describe how come the check is not reliable without this patch? It might be worth fixing the underlying reason for the unreliability first. ================ Comment at: clang/include/clang/Lex/HeaderSearch.h:121 + /// Alias that this header is known as. + llvm::SmallString<64> Alias; + ---------------- I think `HeaderFileInfo` is supposed to be very small, hence the bit packing. Adding `SmallString` here might negatively impact performance. See https://reviews.llvm.org/D104344#inline-1039503 Note that `HeaderFileInfo` used to track aliases, but does not anymore: https://reviews.llvm.org/D123885 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
