upsj added inline comments.

================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:448-450
+    return Type->isReferenceType() &&
+                   !Type.getNonReferenceType().isConstQualified()
+               ? (Type->isLValueReferenceType() ? "&" : "&&")
----------------
It probably doesn't make too much sense to highlight r-value references here, 
since it should be much clearer from context that they are either temporaries 
or explicitly std::move'd


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124359/new/

https://reviews.llvm.org/D124359

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to