vitalybuka added inline comments.
================ Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:6 +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// ---------------- vitalybuka wrote: > can you please either revert ignore this one ================ Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1352 (VE.getValueID(GV.getInitializer()) + 1)); Vals.push_back(getEncodedLinkage(GV)); Vals.push_back(getEncodedAlign(GV.getAlign())); ---------------- all serialization stuff deserve own patch, then rebase the rest on that ================ Comment at: llvm/lib/IR/AsmWriter.cpp:3550 + Out << ", sanitize_address"; + if (MD.HasSanitizer(SanitizerMetadata::HWAddress)) + Out << ", sanitize_hwaddress"; ---------------- it extends IR language, corresponding documentation needs to be updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits