[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

[Fred Tingaud via Phabricator via cfe-commits]

frederic-tingaud-sonarsource marked an inline comment as done.
frederic-tingaud-sonarsource added inline comments.


================
Comment at: clang/include/clang/Analysis/ConstructionContext.h:122-124
     assert(isa<CallExpr>(E) || isa<CXXConstructExpr>(E) ||
-           isa<CXXInheritedCtorInitExpr>(E) || isa<ObjCMessageExpr>(E));
+           isa<CXXDeleteExpr>(E) || isa<CXXInheritedCtorInitExpr>(E) ||
+           isa<ObjCMessageExpr>(E));
----------------
martong wrote:
> I think we could use the variadic `isa` template .
Because assert is a macro, the commas of variadic templates break it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124845/new/

https://reviews.llvm.org/D124845

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits