xazax.hun added a comment.

Most checks in Clang Tidy will run relatively quickly as they usually can do 
most/all of their work in a single traversal. I wonder whether flow sensitive 
checks will prove to be a bit slower. I think adding slower checks to Tidy is 
fine, but it would be nice to properly set the expectations to the user (e.g. 
if an IDE is running Tidy in the background it might want to opt out from flow 
sensitive checks if they turn out to be slow). In case the performance is good, 
I think it should be fine as is. Otherwise I wonder if we want to add something 
like a tag to mark flow sensitive checks and give an option to turn them off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121120/new/

https://reviews.llvm.org/D121120

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to