dexonsmith added a comment.

In D125488#3510320 <https://reviews.llvm.org/D125488#3510320>, @akyrtzi wrote:

> In D125488#3510297 <https://reviews.llvm.org/D125488#3510297>, @dexonsmith 
> wrote:
>
>> [To be clear, my question was because I don't see this patch deleting the 
>> code path that minimizes / saves-minimized sources. Can/should we delete the 
>> "minimize sources" code path?]
>
> Oh, this is removed in the prior patch in the review stack 
> (https://reviews.llvm.org/D125487)

Seems unfortunate to have a temporary regression in the commit stack, since 
then you can't push incrementally (or bisect). Can the prior patch leave behind 
the feature in the DependencyFilesystem, and this patch delete it now that 
clang-scan-deps doesn't depend on it for performance? (Or ignore me if I'm 
still not understanding...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125488/new/

https://reviews.llvm.org/D125488

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to