ken-matsui added a comment. @nathanchance
Oops, thank you for your comment! I would like to work on a hotfix patch for this issue. @aaron.ballman Should we entirely opt-out of this suggestion on `.S` files? I think there are other approaches here, such as decreasing the max edit distance to avoid suggesting this case in `.S` files, but this approach is avoiding just this edge case so that it would possibly bring a new issue like this. Conversely, opting out of this suggestion on the whole `.S` files will not be able to catch any typoes. Considering possible edge cases (`#` directives are also treated as comments), I think opting out would be the only way, unfortunately. What do you think? For now, I will create a patch opting out of this suggestion on `.S` files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
