MaskRay added a comment. The differential has the same intention/subject as D118352 <https://reviews.llvm.org/D118352>. In such a case reusing the preexisting differential would have been better. I have left more comments on https://reviews.llvm.org/D125825#3522911
Note: a revert was committed (https://reviews.llvm.org/D118352#3368921) in 11 hours after the problem was reported. It was fairly legitimate. The user pushing the revert helps maintain build bots green. (Some groups may be more aggressive, e.g. they may leave a comment and perform a revert in 10 minutes. Technically that is also fine, but sometimes can be done better.) In this particular case, I believe the problem was just a Mach-O platform differential that Mach-O IR output doesn't use `dso_local `. This is very common when adding new tests to `test/clang/CodeGen*` and contributors often neglect it. If I had seen the failure in time, I would have tried fixing the test as it is quite straightforward, instead of reverting it. (Thanks for adding #clang-language-wg <https://reviews.llvm.org/tag/clang-language-wg/> since this was a patch that some folks would like to subscribe to.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122256/new/ https://reviews.llvm.org/D122256 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
